fix(blob): base64 includes additional characters #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
william-silversmith
changed the title
william-silversmith
changed the title
product-auto-label
bot
added
the
api: storage
william-silversmith
changed the title
william-silversmith
changed the title
william-silversmith
force-pushed
the
master
branch
from
55c8a41 to
30e6e94
Compare
HemangChothani
requested review from
tseaver and
frankyn
and removed request for
tseaver
william-silversmith
added a commit
to seung-lab/cloud-files
that referenced
this pull request
Sep 2, 2020
Waiting on googleapis/python-storage#258 Until that patch is released, GCS will error on perfectly good files randomly if + or / characters are included in the base64 representation of the hash.
tseaver
approved these changes
Sep 2, 2020
tseaver
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
|
Thank you again Tres! Sorry for the boo boo. |
2 tasks
MartinKilonzo
pushed a commit
to MartinKilonzo/python-storage
that referenced
this pull request
Sep 15, 2020
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. https://en.wikipedia.org/wiki/Base64 <img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. https://en.wikipedia.org/wiki/Base64 <img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. https://en.wikipedia.org/wiki/Base64 <img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters.
https://en.wikipedia.org/wiki/Base64