Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

fix: update sample for task name #120

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix: update sample for task name #120

merged 1 commit into from
Jun 21, 2021

Conversation

averikitsch
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@arithmetic1728 @busunkim96 I believe these samples were generated, does this change need to go somewhere up stream?

@averikitsch averikitsch requested a review from a team as a code owner June 21, 2021 16:11
@averikitsch averikitsch requested review from crwilcox and removed request for a team June 21, 2021 16:11
@product-auto-label product-auto-label bot added the api: cloudtasks Issues related to the googleapis/python-tasks API. label Jun 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 21, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the regular handwritten samples, so making the change here should be enough. :)

@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2021
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2021
@averikitsch
Copy link
Contributor Author

I am not sure why the docs presubmit is failing

@busunkim96
Copy link
Contributor

docs-presubmit is an unrelated failure and @dandhlee is already looking into it :)

This should be good to merge now.

@averikitsch averikitsch merged commit b1be2de into master Jun 21, 2021
@averikitsch averikitsch deleted the task-name branch June 21, 2021 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudtasks Issues related to the googleapis/python-tasks API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants