Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strange interaction with autorelease: snooze and the GitHub app #1583

Closed
chingor13 opened this issue Aug 18, 2022 · 1 comment
Closed

strange interaction with autorelease: snooze and the GitHub app #1583

chingor13 opened this issue Aug 18, 2022 · 1 comment
Assignees
@chingor13
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

I think we're seeing weirdness with the snooze functionality because the GitHub app is marking the pull request as autorelease: closed when the PR is closed (even with snoozing).

Merged release PR without autorelease: pending label

Closed, snoozed PR

updated code for 741, but update requested for 713

Then it the library tries to reopen the snoozed PR and there is an existing PR open for that branch so validation fails

Validation Failed: {"resource":"PullRequest","code":"custom","field":"state","message":"state cannot be changed. There is already an open pull request from release-please--branches--master to master."}
@chingor13 chingor13 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 18, 2022
@chingor13 chingor13 self-assigned this Aug 18, 2022
@SurferJeffAtGoogle
Copy link
Contributor

This issue will fall out of SLO in 6 days.

@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 30, 2023
@chingor13 chingor13 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @SurferJeffAtGoogle