Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError #1675

Closed
github-actions bot opened this issue May 11, 2023 · 8 comments · Fixed by #1915 or #2291
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@github-actions
Copy link

The build has failed : https://github.com/googleapis/gapic-generator-java/actions/runs/4942995036

@mpeddada1
Copy link
Contributor

Stacktrace:

Error:  Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.529 s <<< FAILURE! - in com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest
Error:  com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testOnResponseError  Time elapsed: 2.064 s  <<< FAILURE!
value of: await(...)
expected to be true
	at com.google.api.gax.httpjson.HttpJsonDirectServerStreamingCallableTest.testOnResponseError(HttpJsonDirectServerStreamingCallableTest.java:267)

@mpeddada1 mpeddada1 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 11, 2023
@burkedavison burkedavison changed the title Nightly build for Java 17 on windows-2022 failed. gax-java(windows): Flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError May 15, 2023
@meltsufin meltsufin added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 10, 2023
@meltsufin
Copy link
Member

@lqiu96 @blakeli0 Can we prioritize fixing this? It's causing a lot of flaky failures.

@lqiu96
Copy link
Contributor

lqiu96 commented Aug 10, 2023

@lqiu96 @blakeli0 Can we prioritize fixing this? It's causing a lot of flaky failures.

Sure. I'll take a look.

@lqiu96
Copy link
Contributor

lqiu96 commented Aug 11, 2023

Having a difficult time reproducing this problem on a Windows cloudtop with Java 11. Ran this test for 40k invocations and all passed. Multiple 10k invocation runs have resulted in all passing tests. Need to take another look. Maybe the nightly job is set up differently?

@blakeli0
Copy link
Collaborator

Maybe the nightly job is set up differently?

What is the hardware specification for the cloudtop machine and the Github action machine? I guess the machine Github action uses is much worse than the cloudtop. In which case, I don't think we can do much other than increase the wait time. I gave the test itself a quick review and I don't see anything wrong with the setups.

@lqiu96
Copy link
Contributor

lqiu96 commented Aug 16, 2023

Maybe the nightly job is set up differently?

What is the hardware specification for the cloudtop machine and the Github action machine? I guess the machine Github action uses is much worse than the cloudtop. In which case, I don't think we can do much other than increase the wait time. I gave the test itself a quick review and I don't see anything wrong with the setups.

Yeah that seems very likely. I'll spend a few hours looking into this issue and I'll double the wait time if I'm still stuck.

@blakeli0
Copy link
Collaborator

Reopening this issue as it is happening again last night #1939

@suztomo
Copy link
Member

suztomo commented Dec 14, 2023

Marking this as fixed in #2291. Let's reopen if this recurs.

@suztomo suztomo closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
5 participants