-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autopopulate fields in the request #2353
Conversation
...om/google/api/generator/gapic/composer/common/AbstractTransportServiceStubClassComposer.java
Outdated
Show resolved
Hide resolved
...om/google/api/generator/gapic/composer/common/AbstractTransportServiceStubClassComposer.java
Show resolved
Hide resolved
...om/google/api/generator/gapic/composer/common/AbstractTransportServiceStubClassComposer.java
Show resolved
Hide resolved
gapic-generator-java/src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/RetryingCallable.java
Outdated
Show resolved
Hide resolved
showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITAutoPopulatedFields.java
Outdated
Show resolved
Hide resolved
showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITAutoPopulatedFields.java
Outdated
Show resolved
Hide resolved
showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITAutoPopulatedFields.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In follow up PRs, please extract the golden unit test cases to a separate proto/yaml.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/model/FieldTest.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/test/java/com/google/api/gax/rpc/RetryingCallableTest.java
Outdated
Show resolved
Hide resolved
…pic/model/FieldTest.java Co-authored-by: Blake Li <blakeli@google.com>
…ableTest.java Co-authored-by: Blake Li <blakeli@google.com>
Please retry analysis of this Pull-Request directly on SonarCloud |
Quality Gate passed for 'java_showcase_integration_tests'The SonarCloud Quality Gate passed, but some issues were introduced. 8 New issues |
As a clean-up follow up to #2353, this PR refactors the unit golden tests for the autopopulation feature to a separate, new proto called `auto_populate_field_testing.proto`.
* feat: autopopulate fields in the request * revert showcase golden changes * add AbstractTransportServiceStubClassComposerTest * add REST implementation * add GrpcDirectCallableTest * remove unnecessary null check * add field info proto registry and more unit test cases * add HttpJsonDirectCallableTest * refactor AbstractTransportServiceSTubClassComposer * add more unit tests for Field * feat: refactor request mutator expression * fix goldens * add showcase test for autopopulation * fix lint * change assertion in showcase test * refactor for sonarcloud * sonarcloud fixes * sonarcloud * sonarcloud fix * fix sonarcloud * slight refactoring * revert changes to directCallable and replace with retryable Callable * overload retrying Callables method * change license header format * fix license header * fix showcase lint * add comment * add showcase comment * add CallableTest and httpjson Retrying test * fix lint * add RetryingCallable test and some refactoring * refactor GrpcCallableFactory * remove extraneous from HttpJsonDirectCallableTest * remove FakeHttpJsonChannel * revert changes to tests for extra param * refactoring * Update gapic-generator-java/src/test/java/com/google/api/generator/gapic/model/FieldTest.java Co-authored-by: Blake Li <blakeli@google.com> * Update gax-java/gax/src/test/java/com/google/api/gax/rpc/RetryingCallableTest.java Co-authored-by: Blake Li <blakeli@google.com> --------- Co-authored-by: Blake Li <blakeli@google.com>
As a clean-up follow up to #2353, this PR refactors the unit golden tests for the autopopulation feature to a separate, new proto called `auto_populate_field_testing.proto`.
Follow up to: #2312
This adds autopopulation of fields within the Request message for protos that are configured. This currently only supports UUID4.