Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error_prone_annotations dependency is inconsistent in this repo #2576

Open
diegomarquezp opened this issue Mar 14, 2024 · 2 comments
Open

error_prone_annotations dependency is inconsistent in this repo #2576

diegomarquezp opened this issue Mar 14, 2024 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@diegomarquezp
Copy link
Contributor

We have errorprone.version defined in

sdk-platform-java/java-shared-dependencies/third-party-dependencies/pom.xml

Line 33 in f5f201e

<errorprone.version>2.26.1</errorprone.version>

We have error_prone_annotations with a different version in

sdk-platform-java/api-common-java/pom.xml

Line 66 in f5f201e

<version>2.24.1</version>

@diegomarquezp
Copy link
Contributor Author

Maybe it's better if we declare it in shared-config

@diegomarquezp
Copy link
Contributor Author

#2574 works around this, for now.

@zhumin8 zhumin8 added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 15, 2024
@mpeddada1 mpeddada1 mentioned this issue Oct 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhumin8 @diegomarquezp