Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate usages of Map<String, VariableExpr> in AbstractTransportServiceStubClassComposer #3077

Open
lqiu96 opened this issue Jul 31, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Jul 31, 2024

Related issue: #3076

We have attempted to migrate Callable generation away from the implementation in createCallableClassMembers(). This was because the return was a mapping of String (callableName) to the VariableExpr. The callableName was being used to determine the type of RPC and was causing a bug.

Milestone 1: Migrate away completely from any usage of createCallableClassMembers()
Milestone 2: Investigate the possibility migrating away completely from using any Map<String, VariableExpr> mapping in the file

@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant