Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): use quiet flag rather than silent #3491

Merged
merged 1 commit into from
Oct 7, 2017
Merged

fix(eslint): use quiet flag rather than silent #3491

merged 1 commit into from
Oct 7, 2017

Conversation

paulirish
Copy link
Member

the yarn lint --silent now breaks in yarn 1.0 because --silent is being passed to eslint. before 1.0, it was not passed. (whoops)

@paulirish paulirish requested a review from brendankenny October 5, 2017 23:57
@paulirish paulirish changed the title fix(eslint): use quiet flag rather than quiet fix(eslint): use quiet flag rather than silent Oct 5, 2017
brendankenny
brendankenny approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎆 💥 👂 📢 🔊 📣

@brendankenny brendankenny merged commit 320eb1f into master Oct 7, 2017
@brendankenny brendankenny deleted the silentquiet branch October 7, 2017 01:31
@dependencies dependencies bot mentioned this pull request Dec 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny