Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(emulation): remove use of deprecated Emulation.setVisibleSize #3536

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

paulirish
Copy link
Member

This protocol method was made redundant in 61.0.3155.0

It's a noop for us now. Trace screenshots are no different.

fixes #2831

@patrickhulce
Copy link
Collaborator

Is 61 fully out now? It's been pretty slow going

@paulirish
Copy link
Member Author

Is 61 fully out now? It's been pretty slow going

Shipped on sept 5th!
stable is really only a concern for our extension users, but not our devtools people. and typically not CLI, though we don't know for sure.

chrome doesn't support stable-1 releases and i don't think we should either. 😀

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use Emulation.setVisibleSize
3 participants