Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(codereview): add CODEOWNERS file #3591

Merged
merged 1 commit into from
Oct 17, 2017
Merged

misc(codereview): add CODEOWNERS file #3591

merged 1 commit into from
Oct 17, 2017

Conversation

paulirish
Copy link
Member

patrickhulce
patrickhulce approved these changes Oct 17, 2017
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to request review of all owners so we might need something extra to decide who actually takes what, but seems like a great start 👍

@paulirish
Copy link
Member Author

paulirish commented Oct 17, 2017 •
edited
Loading

seems to request review of all owners

yah. i think it'll probably be a bit overkill, but let's give it a whirl for a few days.. facebooks' mention bot has a little more configurability but it'll take a while to get up and running right.

and i was unable to find a tool that automates our waiting4reviewer/committer labels. so we'll probably need to write our own bot for that.

@patrickhulce
Copy link
Collaborator

patrickhulce commented Oct 17, 2017 •
edited
Loading

so we'll probably need to write our own bot for that.

it shouldn't be too hard to press git3po into service there

@paulirish paulirish merged commit b6a676a into master Oct 17, 2017
@paulirish paulirish deleted the codeowners branch October 17, 2017 20:48
@dependencies dependencies bot mentioned this pull request Dec 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @patrickhulce