Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use undated Apache 2 LICENSE file #3700

Merged
merged 2 commits into from
Nov 10, 2017
Merged

misc: use undated Apache 2 LICENSE file #3700

merged 2 commits into from
Nov 10, 2017

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Oct 31, 2017

No description provided.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, weirdly spotted :)

But isn't this line just supposed to be the boilerplate Copyright [yyyy] [name of copyright owner], since it's just the license giving general info on how it's used, not us giving info on how to use the license on our project?

@ebidel
Copy link
Contributor Author

ebidel commented Oct 31, 2017

You're supposed to append to the generic license and modify it with your own info:

APPENDIX: How to apply the Apache License to your work.

      To apply the Apache License to your work, attach the following
      boilerplate notice, with the fields enclosed by brackets "[]"
      replaced with your own identifying information. (Don't include
      the brackets!)  The text should be enclosed in the appropriate
      comment syntax for the file format. We also recommend that a
      file or class name and description of purpose be included on the
      same "printed page" as the copyright notice for easier
      identification within third-party archives.

@brendankenny
Copy link
Member

right, but it's telling you how to do that when attaching that header to your work, not to do it to the text below. The internet seems mixed on this, but most of the Apache projects seem to do it this way, and presumably they know how to do it right (e.g. couchdb, though notably this one does not)

@brendankenny brendankenny changed the title LICENSE: 2016 is when the project started misc: use undated Apache 2 LICENSE file Nov 10, 2017
@brendankenny brendankenny merged commit f7b75a7 into master Nov 10, 2017
@brendankenny brendankenny deleted the ebidel-patch-3 branch November 10, 2017 21:43
christhompson pushed a commit to christhompson/lighthouse that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants