Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): increase default timeout to 45s #3741

Merged
merged 1 commit into from
Nov 7, 2017
Merged

core(driver): increase default timeout to 45s #3741

merged 1 commit into from
Nov 7, 2017

Conversation

patrickhulce
Copy link
Collaborator

closes #3733

things to consider:

  • this might break folks who were running on bad hardware and needed to keep traces small (counter: it currently breaks for plenty of these sites at 30s already)
  • scores will change from 0 to ~8 at sites with TTI at 30s

@vinamratasingal-zz
Copy link

Huge fan of this- increasing timeouts will (I think) reduce our error rates.

brendankenny
brendankenny approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@brendankenny
Copy link
Member

we got a verbal 👍 from @paulirish so let's do this!

@brendankenny brendankenny merged commit 8a1af52 into master Nov 7, 2017
@brendankenny brendankenny deleted the increase_timeout branch November 7, 2017 19:15
christhompson pushed a commit to christhompson/lighthouse that referenced this pull request Nov 28, 2017
@patrickhulce @christhompson
core(driver): increase default timeout to 45s (GoogleChrome#3741)
5197231
@dependencies dependencies bot mentioned this pull request Dec 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core: increase page load timeout to 45s
4 participants
@patrickhulce @vinamratasingal-zz @brendankenny @wardpeet