Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(image-usage): add null check for parentElement #3779

Merged
merged 5 commits into from
Nov 8, 2017

Conversation

AkshayIyer12
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@AkshayIyer12
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@wardpeet
Copy link
Collaborator

wardpeet commented Nov 8, 2017

@AkshayIyer12 Thanks for fixing this bug! Do you have a webpage where this audit fails? is it possible to create a unit test for this one?

@patrickhulce
Copy link
Collaborator

@wardpeet yeah the details are in #3731 :)

unfortunately a unit test is tricky since its eval'd in the browser, but a smoke test would be nice

Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on @AkshayIyer12 !! 🎉

@patrickhulce patrickhulce merged commit 190638a into GoogleChrome:master Nov 8, 2017
christhompson pushed a commit to christhompson/lighthouse that referenced this pull request Nov 28, 2017
* core(image-usage): add null check for parentElement

* core(image-usage): add null check for parentElement

* add smoke test

* add issue link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants