-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(uses-webp): tweak text to be more next-gen focused #3985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw i found this table (from here) useful:
informative: true, | ||
helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' + | ||
helpText: 'JP2, JPEG XR, and WebP often provide better compression than PNG or JPEG, ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the elongated names
Image formats like JPEG 2000, JPEG XR, and WebP often provide better compression than PNG or JPEG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing comment: as part of the research we did for images.guide, it turned out that a lot of users could get some pretty hefty wins from adopted MozJPEG. This isn't technically a next-gen format, but a JPEG optimizer. Unsure if you'd want to cater for those types of recommendations.
@@ -21,9 +21,9 @@ class UsesWebPImages extends ByteEfficiencyAudit { | |||
static get meta() { | |||
return { | |||
name: 'uses-webp-images', | |||
description: 'Serve images as WebP', | |||
description: 'Serve images in next-gen formats', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there's a better name than "next-gen". The closest i'm getting is "2010-era". But that doesnt' seem worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about just "better" or "superior"?
e11fd33
to
f17348e
Compare
WFM. over to @vinamratasingal as this is user facing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That table looks dope. We should add that to the docs!
Thanks for tagging me Paul- looks good, just have a few followup comments :)
@@ -21,10 +21,10 @@ class UsesWebPImages extends ByteEfficiencyAudit { | |||
static get meta() { | |||
return { | |||
name: 'uses-webp-images', | |||
description: 'Serve images as WebP', | |||
description: 'Serve images in superior formats', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Superior formats" seems a little judgy. Can we just say "next-gen formats" or "performant formats"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'next-gen' was nixed, but performant SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind paul's good with "next-gen" afterall 👍
helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' + | ||
'which means faster downloads and less data consumption. ' + | ||
helpText: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' + | ||
'compression than PNG or JPEG, which means faster downloads and less data consumption. ' + | ||
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/webp).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we update this documentation to explain the different formats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed we should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed a bug against Kayce to update the docs for next sprint :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cool, I also just got a brain dump from him on how I can update stuff and seems straightforward when we have changes to docs like this that aren't new material :)
informative: true, | ||
helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' + | ||
'which means faster downloads and less data consumption. ' + | ||
helpText: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to mention something here about different browser support for each, or nah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah we have a policy to keep the details in the docs
👍 |
closes #3557