Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_audit(seo): manual SEO audits #4108

Merged
merged 2 commits into from
Jan 3, 2018

Conversation

kdzwinel
Copy link
Collaborator

Adds two manual SEO audits.

screen shot 2017-12-22 at 02 27 23

Closes #3119
Closes #3183
Closes #3184

@@ -241,6 +243,10 @@ module.exports = {
title: 'Crawling and Indexing',
description: 'To appear in search results, crawlers need access to your app.',
},
'manual-seo-checks': {
title: 'Manual SEO Validation',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both accessibility and PWA categories call this subcategory 'Additional items to manually check' - IMO we should have the same name here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

static get meta() {
return Object.assign({
name: 'mobile-friendly',
helpText: 'Take the [Mobile-Friendly Test](https://search.google.com/test/mobile-friendly) to see how easily a visitor can use your page on a mobile device. [Learn more](https://developers.google.com/search/mobile-sites/).',
Copy link
Collaborator

@patrickhulce patrickhulce Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that LH is all about mobile web advice, I'm assuming the plan is to convert this audit into an automatic test at some point? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this is currently using these 6 rules in the check: https://support.google.com/webmasters/answer/6352293?utm_source=search_console&utm_campaign=sc-mft-test

once we have coverage for all of them in LH, we can migrate this to a multicheckaudit and drop the recommendation to use MFT as we'll be testing the exact same thing. (we could also validate there is no significant difference in results across x000 URLs)

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the category name piece you've identified is the only change we're waiting on, LGTM otherwise!

cc @rviscomi if it needs his sign-off :)

@kdzwinel
Copy link
Collaborator Author

kdzwinel commented Jan 3, 2018

Done 👌

screen shot 2018-01-03 at 02 10 27

Thank you @patrickhulce & @rviscomi for a review!

@paulirish
Copy link
Member

lgtm from me. @rviscomi anything from you?

@patrickhulce patrickhulce merged commit 175396a into GoogleChrome:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants