Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove legacy domhtml output #4176

Merged
merged 2 commits into from
Jan 9, 2018
Merged

cli: remove legacy domhtml output #4176

merged 2 commits into from
Jan 9, 2018

Conversation

paulirish
Copy link
Member

This was still hanging around. We can nuke it nowadays.

@patrickhulce
Copy link
Collaborator

technically a breaking change, any rush on it or cool letting it chill? :)

@paulirish
Copy link
Member Author

technically a breaking change, any rush on it or cool letting it chill? :)

found we would break this dude: https://github.com/dschmeh/lighthouseR/blob/56947d2f970ba1df2af38962f7fa5c80d8e03bb4/R/lighthouse.R

no other users i could find that we'd break.

happy to do this whenever.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@paulirish paulirish merged commit b433a2a into master Jan 9, 2018
@paulirish paulirish deleted the removedomhtml branch January 9, 2018 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants