-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(chrome-launcher): Upgrade chrome-launcher #4192
Conversation
ruh roh. looks like i did indeed break the TS typings with the folder move: GoogleChrome/chrome-launcher#69 (comment) |
51eb685
to
92e9105
Compare
just rebased to get the #4209 fix that was breaking this PR. why was it breaking this PR out of the blue? that, we'll never know. 🐩 |
Is there a test we could add to chrome-launcher to prevent this? |
yes i would love that. not how to write it, personally. you might know better than most of us. :) |
Not 100% sure but we can write a test like this:
By default it checks in the root directory |
i was thinking a more functional test. e.g. some module that require()s chrome-launcher successfully typechecks with TS. filed as GoogleChrome/chrome-launcher#83 |
even though travis is busted, appveyor is happy. shipping. |
Upgrade chrome-launcher to 0.10.1.
I wasn't sure why chrome-launcher does not have a
^
in package.json so feel free to decline this PR.