-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report(category): enable all categories to show audit groups #4278
report(category): enable all categories to show audit groups #4278
Conversation
|
||
/* globals self, Util */ | ||
|
||
class PerformanceCategoryRenderer extends CategoryRenderer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulirish category-renderer.js
was huuuuge. I started refactor by splitting it up into three files (perf, a11y, default). Hope that's OK? In the next step I'll move audit group support from a11y to the default renderer and (hopefully?) nuke the a11y render.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds great
06d2307
to
f157e2c
Compare
e462ad4
to
12c8c26
Compare
@@ -0,0 +1,194 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a new file we need to update https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/audits2/module.json#L20 . Because it's missing yarn compile-devtools
is currently failing.
[Edit] somehow it passes on travis, no idea what's going on
|
||
this._detailsRenderer.setTemplateContext(this._templateContext); | ||
/** @protected {!DOM} */ | ||
this.dom = dom; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn compile-devtools
forced me to remove _
prefix from protected variables 😿
@patrickhulce @paulirish as far as I remember, we agreed it to leave this as is and don't migrate to getters ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took this for a spin and things look identical between master and this (except for the reportGroups in SEO)
nice work!
Enables audit grouping, previously restricted to accessibility category only, for all categories. Additionally, enables 'non applicable' group for all categories.
Before
After
Example report: http://lh-audit-grouped.bitballoon.com/
Fixes #4093