Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(tracing-processor): fix scheduleable task logic #4480

Merged
merged 12 commits into from
Feb 8, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Feb 8, 2018

makes appveyor green again!

this CL changed the name of scheduleable tasks from TaskQueueManager::ProcessTaskFromWorkQueue to ThreadControllerImpl::DoWork we now support both and throw loudly if we don't find any tasks at all

@paulirish
Copy link
Member

This fixes a bug with Chrome Canary: https://bugs.chromium.org/p/chromium/issues/detail?id=783309&desc=2#c22

@paulirish
Copy link
Member

LGTM but waiting for CI

@patrickhulce patrickhulce merged commit a517412 into master Feb 8, 2018
@patrickhulce patrickhulce deleted the fix_canary_imgs branch February 8, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants