deps(axe-core): update axe-core to latest (beta) release #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benschwarz
changed the title
benschwarz
changed the title
|
These performance improvements are indeed amazing 💯, are we comfortable shipping a beta release of axe long-term though? If it's buggy we'll hear about it for 18+ weeks until it finally leaves Chrome stable 😆 How vetted is it? |
|
I’m not super familiar with the release schedule of axe, but after it hits a non beta we’d want to move to the stable ASAP. |
|
with the a11y gatherer went from taking 31s to 9s on my machine. \o/ |
|
Let's wait for dequelabs/axe-core#731 to land and the beta it ships in. |
done. |
paulirish
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a number of important performance fixes in the latest axe-core release that will significantly improve the speed of LH (and in many cases allow the accessibility audits to complete successfully for sites with big dom).
Ref: dequelabs/axe-core/issues/696
Ref: dequelabs/axe-core/issues/701
Ref: dequelabs/axe-core/issues/702
Top work, @paulirish 💓