Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(response-compression): also check x-original-content-encoding #4607

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

jianzhoufeng
Copy link
Contributor

@patrickhulce

PTAL.

Thanks!

@jianzhoufeng jianzhoufeng changed the title (core) response-compression: also check x-original-content-encoding core(response-compression): also check x-original-content-encoding Feb 23, 2018
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

@patrickhulce
Copy link
Collaborator

one more question though @jianzhoufeng, does this mean the transferSize properties on network records are also the decoded length or are those alright?

@jianzhoufeng
Copy link
Contributor Author

@patrickhulce: The transferSize set from encodedDataLength of the Network.loadingFinished event is still the encoded size. If the transferSize is set from other devtools events, it might be the decoded length, though I need to check.

@patrickhulce patrickhulce merged commit cb7bcc2 into GoogleChrome:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants