Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(closure): fix BSD sed calls within compile-devtools #4736

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

paulirish
Copy link
Member

This at least allows you to reproduce the error from #4735 locally on a mac. (BSD sed vs GNU sed strikes again, ugh).

But it doesn't fix the actual error. I'm stumped on that so far.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny merged commit 17a8bcc into master Mar 12, 2018
@brendankenny brendankenny deleted the fixclosuredevtools-onmac branch March 12, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants