Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove cache-start-url audit #4760

Merged
merged 1 commit into from
Mar 14, 2018
Merged

core: remove cache-start-url audit #4760

merged 1 commit into from
Mar 14, 2018

Conversation

patrickhulce
Copy link
Collaborator

in the name of #4333

audit was unused, not in the config and rendered unnecessary by the assessOfflineStartUrl check in webapp-install-banner

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎶 at last... 🎶

@patrickhulce patrickhulce merged commit c8d84fa into master Mar 14, 2018
@patrickhulce patrickhulce deleted the remove_cache_start branch March 14, 2018 21:45
@patrickhulce
Copy link
Collaborator Author

oh whoops sorry @paulirish brendan just assigned you, this cool?

@paulirish
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants