Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(emulation): update Chrome userAgent to 66 #4779

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

paulirish
Copy link
Member

overdue. :)

i'm also open to updating the Android version. wdyt?

@paulirish
Copy link
Member Author

updating android version

image

so right now we're on the most common android version. so actually that seems reasonable. we have a 3-4 year old device on the most common android version. WFM, personally. 👍

sg?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For evergreen Chrome it's somewhat easier to forgive more aggressive UA cutoffs than it is anyone leaving Android M behind today

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! sticking to current Android wfm too

@patrickhulce patrickhulce merged commit 202d04b into master Mar 15, 2018
@patrickhulce patrickhulce deleted the bumpchromeua branch March 15, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants