tests(smokehouse): adjust byte efficiency CPU multiplier #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
appveyor_lantern_fix
branch
from
12f4fb6
to
abcb6c8
Compare
patrickhulce
changed the title
paulirish
reviewed
Mar 19, 2018
| @@ -136,6 +136,8 @@ class UnusedBytes extends Audit { | |||
| */ | |||
| static createAuditResult(result, graph) { | |||
| const simulatorOptions = PredictivePerf.computeRTTAndServerResponseTime(graph); | |||
| // TODO: calibrate multipliers, see https://github.com/GoogleChrome/lighthouse/issues/820 | |||
| Object.assign(simulatorOptions, {cpuTaskMultiplier: 1, layoutTaskMultiplier: 1}); | |||
There was a problem hiding this comment.
why reset these multipliers to 1 rather than their defaults?
There was a problem hiding this comment.
well in our pre-lantern case the throttling is usually being applied by devtools, so pumping it through another 4x multiplier is sorta unfair. This shouldn't really matter once #4766 and follow-ups land
paulirish
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4808