Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(domstats): useIsolation within domstats #4811

Merged
merged 1 commit into from
Mar 19, 2018
Merged

core(domstats): useIsolation within domstats #4811

merged 1 commit into from
Mar 19, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Mar 19, 2018 •
edited
Loading

fixes https://sentry.io/google-lighthouse/lighthouse/issues/408582172/ our 6th most common error.

error is "Set is not a constructor" always coming from elementPathInDOM

patrickhulce
patrickhulce approved these changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems safe 👍

@paulirish paulirish merged commit 0cddcd3 into master Mar 19, 2018
@paulirish paulirish deleted the set-is-not-a-constructor branch March 19, 2018 19:55
paulirish added a commit that referenced this pull request Mar 22, 2018
@paulirish
core(domstats): useIsolation within domstats (#4811)
12918c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @patrickhulce @devtools-bot