report: move html report from v2/ dir to html/ #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
ebidel,
patrickhulce,
paulirish and
vinamratasingal-zz
as code owners
brendankenny
force-pushed
the
reportdir
branch
2 times, most recently
from
32755e9
to
cf72aa7
Compare
paulirish
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #4999
As (we've kind of) discussed, with
report-generator.jsnow handling all report generation and with v3 report changes happening iteratively, it makes sense to smoosh the directories a bit.ReportGenerator is now:
/lighthouse-core/report/v2/report-generator.js->/lighthouse-core/report/report-generator.jsand html report stuff is now
/lighthouse-core/report/v2/*->/lighthouse-core/report/html/*Not really a breaking change since #4999 made report generation handled by runner internally :) :)