Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(lantern): rename Simulation.Result.nodeTiming to be plural #5038

Merged
merged 3 commits into from
Apr 25, 2018
Merged

core(lantern): rename Simulation.Result.nodeTiming to be plural #5038

merged 3 commits into from
Apr 25, 2018

Conversation

paulirish
Copy link
Member

No description provided.

brendankenny
brendankenny approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@patrickhulce patrickhulce merged commit f82680f into master Apr 25, 2018
@patrickhulce patrickhulce deleted the nodeTimings branch April 25, 2018 21:23
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@paulirish @kdzwinel
core(lantern): rename Simulation.Result.nodeTiming to be plural (Goog…
e39133b 
…leChrome#5038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @brendankenny @patrickhulce @devtools-bot