core(lantern): use securityOrigin on record #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 30, 2018
|
Can you add a description of the bug to the PR for future git blaming? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a good bug while working on #5070 that's relatively independent
basically if you try to call network analysis before you create a network node from the network record, all the origins will be undefined and so the
additionalRttByOriginandserverResponseTimeByOriginare totally useless for the future cached runs that do properly create a network node from the network record. We originally did this because callingnew URL()to get the origin was super expensive and these are somewhat hot paths, while the function call + getter is a bit more expensive, it's still not nearly as bad asnew URL. Seems OK until it crops up as a bottleneckthis PR reverts the
.origindance we do on network records and just uses.securityOrigin()on the record, if it becomes a big bottleneck again we can further optimize