Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: bump version to 3.0 alpha #5082

Merged
merged 3 commits into from
May 2, 2018
Merged

core: bump version to 3.0 alpha #5082

merged 3 commits into from
May 2, 2018

Conversation

paulirish
Copy link
Member

No description provided.

@patrickhulce
Copy link
Collaborator

🎉

brendankenny
brendankenny approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after golden LHR update

@brendankenny
Copy link
Member

assert.ok(footerContent.includes('Generated by Lighthouse 2'), 'includes lh version');

lol

@paulirish paulirish merged commit f01184d into master May 2, 2018
@paulirish paulirish deleted the threeoh branch May 2, 2018 18:57
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@paulirish @kdzwinel
core: bump version to 3.0 alpha (GoogleChrome#5082)
2abdb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @patrickhulce @brendankenny