misc(viewer): switch to 2x viewer within the same tab #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested review from
brendankenny,
ebidel and
vinamratasingal-zz
as code owners
patrickhulce
approved these changes
May 16, 2018
| @@ -175,19 +175,18 @@ class LighthouseReportViewer { | |||
| } | |||
|
|
|||
| /** | |||
| * Opens new tab with compatible report viewer version | |||
| * Opens legacy viewer in current tab, then renders report | |||
There was a problem hiding this comment.
comment is a bit weird to me since everything that happens after navigating to legacy viewer isn't captured here
| /** | ||
| * @override | ||
| */ | ||
| sendJsonReport() { |
There was a problem hiding this comment.
anything else to undo for viewerPath and whatnot?
|
also viewer compile seems to be complaining on travis |
paulirish
added a commit
that referenced
this pull request
May 16, 2018
paulirish
added a commit
that referenced
this pull request
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5204 used postMessage to open the 2x viewer, but this faces problems with popup blockers.
This PR reverts most of that one, and uses IDB and
location.href = ...to store and open the 2x report.The complementary 2.x branch PR to this one is: #5232