-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(pwa): adjust score weights #5233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup this new scoring is ace.
cc @tjsavage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weights work for me, but not sure if I agree with the "important but not too difficult" comment for https/redirects :P Maybe for a personal or new site, but still difficult for established ones with legacy content/serving/ad systems
sure but a very different kind of difficult, the technical challenge of getting a cert and flipping a server bit is still "not too difficult", wrangling all your third parties and getting all of them to go https is an ecosystem challenge. one could make the claim that making any changes to a legacy site can be supremely challenging, so might as well not classify them at all 🤷♀️ |
@vinamratasingal thoughts? |
so it seems like PWA badging or whatever is independent of these changes. The score re-weighting seems good and should definitely land before the full 3.0 release, so should we move forward with this? |
yes and yes 👍 |
SGTM 👍 |
adjust the PWA score weights to give more credit to speed/offline, less to adding a manifest/1-line meta
You can play around with how this affects score at the calculator
Basically...
Adding manifest alone used to be worth 18, now worth 8
Adding noop service worker used to be worth 9, now worth 4
Adding service worker to make site work offline used to be worth 18, now worth 23
Performance used to be worth 9, now worth 27