misc(scripts): better print-correlations output #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
From the screenshot:
- what does the %error of optimistic/pessimistic numbers mean since there is nothing "real" to measure them against?
- good/ok/bad buckets are sites that are good/ok/bad or sites where the lantern estimate is good/ok/bad? (I assume the lantern estimate since it's listing the bad number going down as green?)
it's also measuring them against the real value, mostly this is for tracking how close the raw optimistic/pessimistic values are without any adjustments :)
correct |
|
@brendankenny any last thoughts on this one? |
brendankenny
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically a total re-write of the
print-correlationsscript, example new output looks like the below and compares the current state to the baseline master state as well! 🎉