Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(i18n): add descriptions to UI strings #5743

Merged
merged 10 commits into from
Jul 27, 2018
Merged

core(i18n): add descriptions to UI strings #5743

merged 10 commits into from
Jul 27, 2018

Conversation

paulirish
Copy link
Member

HUGE TEAM EFFORT.
this is like 9 person-hours of work from @brendankenny, @patrickhulce, and @kusler

So much fun

ref #5719

@paulirish paulirish changed the title core(i18n): add descriptions to UI strings core(i18n): add descriptions to UI strings Jul 27, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 💥 💥

@paulirish paulirish merged commit 600ecba into master Jul 27, 2018
@paulirish paulirish deleted the all_the_strings branch July 30, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants