core(i18n): always use formatted strings for extension popup #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Aug 1, 2018
| @@ -92,4 +113,13 @@ describe('Lighthouse chrome popup', function() { | |||
| assert.equal(titleText, 'Lighthouse'); | |||
| assert.equal(urlText, 'http://example.com'); | |||
| }); | |||
|
|
|||
|
|
|||
| // Kinda lame as the mocked data is already good. | |||
There was a problem hiding this comment.
I guess a unit test (which would still be trivial but at least testing something) would be that the categories passed back are what are in the labels and values of the check boxes? So maybe keep the array passed back by the mocked getDefaultCategories in a top level variable and loop over it here to verify that all the members are there?
(rather than checking for the lack of ICU messages, which doesn't seem possible since the mock doesn't supply any of them)
|
trashed the old test and wrote the one you described. sg? |
yep, LG! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #5727
fixes this:
