core(trace-processor): use new toplevel task event name #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
fix_no_longtasks
branch
from
bfecc6e
to
08ef553
Compare
paulirish
reviewed
Aug 15, 2018
| @@ -9,7 +9,8 @@ | |||
| // first frame of the response. | |||
| const BASE_RESPONSE_LATENCY = 16; | |||
| const SCHEDULABLE_TASK_TITLE = 'TaskQueueManager::ProcessTaskFromWorkQueue'; | |||
| const SCHEDULABLE_TASK_TITLE_ALT = 'ThreadControllerImpl::DoWork'; | |||
| const SCHEDULABLE_TASK_TITLE_ALT1 = 'ThreadControllerImpl::DoWork'; | |||
| const SCHEDULABLE_TASK_TITLE_ALT2 = 'ThreadControllerImpl::RunTask'; | |||
There was a problem hiding this comment.
can you add a comment pointing to https://bugs.chromium.org/p/chromium/issues/detail?id=871204#c11 and indicating its in m69 and m70
| @@ -9,7 +9,8 @@ | |||
| // first frame of the response. | |||
| const BASE_RESPONSE_LATENCY = 16; | |||
| const SCHEDULABLE_TASK_TITLE = 'TaskQueueManager::ProcessTaskFromWorkQueue'; | |||
| const SCHEDULABLE_TASK_TITLE_ALT = 'ThreadControllerImpl::DoWork'; | |||
| const SCHEDULABLE_TASK_TITLE_ALT1 = 'ThreadControllerImpl::DoWork'; | |||
There was a problem hiding this comment.
can you add a comment pointing to https://crrev.com/c/883346
paulirish
approved these changes
Aug 15, 2018
|
Chrome beta: |
brendankenny
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
as @paulirish discovered, there's a new event name for toplevel tasks
ThreadControllerImpl::RunTaskthis adds it so we can handle new Chrome traces.will probably need to be ported back to Chrome beta 😬
Related Issues/PRs
fixes #5832