Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: enableErrorReporting must be undefined by default #5854

Merged
merged 2 commits into from
Aug 17, 2018
Merged

cli: enableErrorReporting must be undefined by default #5854

merged 2 commits into from
Aug 17, 2018

Conversation

brendankenny
Copy link
Member

patrickhulce
patrickhulce approved these changes Aug 17, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix :)

lighthouse-cli/cli-flags.js Outdated
@@ -136,6 +136,7 @@ function getFlags(manualArgv) {
.default('output', ['html'])
.default('port', 0)
.default('hostname', 'localhost')
.default('enable-error-reporting', undefined) // Default so prompted by default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 💯

maybe Undefined so prompted by default though? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

paulirish
paulirish approved these changes Aug 17, 2018
View reviewed changes
lighthouse-cli/bin.js
@@ -97,6 +97,9 @@ if (cliFlags.extraHeaders) {
function run() {
return Promise.resolve()
.then(_ => {
// By default, cliFlags.enableErrorReporting is undefined so the user is
// prompted. This can be overriden with an explicit flag or by the cached
// answer returned by askPermission().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🅼🆅🅿

@brendankenny brendankenny merged commit 52826e5 into master Aug 17, 2018
@brendankenny brendankenny deleted the errorreporting branch August 17, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @paulirish @patrickhulce