core(tsc): remove more reliance on implicit index signatures #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
brendankenny
commented
Aug 20, 2018
| @@ -73,9 +76,11 @@ class NetworkAnalyzer { | |||
| return summaryByKey; | |||
| } | |||
|
|
|||
| /** @typedef {{record: LH.Artifacts.NetworkRequest, timing: LH.Crdp.Network.ResourceTiming, connectionReused?: boolean}} RequestInfo */ | |||
There was a problem hiding this comment.
I apologize for the terrible name here, @patrickhulce :)
There was a problem hiding this comment.
heh, works for me :)
brendankenny
commented
Aug 20, 2018
| @@ -368,6 +368,7 @@ class Runner { | |||
| const ArtifactClass = require('./gather/computed/' + filename); | |||
| const artifact = new ArtifactClass(computedArtifacts); | |||
| // define the request* function that will be exposed on `artifacts` | |||
| // @ts-ignore - doesn't have an index signature, so can't be set dynamically. | |||
| computedArtifacts['request' + artifact.name] = artifact.request.bind(artifact); | |||
There was a problem hiding this comment.
artifact and ArtifactClass are already any here, and computedArtifacts already has a TODO to refactor above this method, so it seems fine to just ignore and keep the issues contained here than to make computedArtifacts have a generic index signature and have it leak into audits, etc.
brendankenny
changed the title
brendankenny
changed the title
brendankenny
changed the title
brendankenny
changed the title
brendankenny
changed the title
brendankenny
changed the title
brendankenny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5873
No real theme here, just scattered fixes where none needed major interventions. Resolves 23 errors when using
typescript@next.The other side of some of these fixes is going explicitly
anyorts-ignore, but it didn't seem worth losing refactoring, intellisense, etc for most of these