Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add i18n 'type' for prlint #5880

Merged
merged 1 commit into from
Aug 21, 2018
Merged

i18n: add i18n 'type' for prlint #5880

merged 1 commit into from
Aug 21, 2018

Conversation

paulirish
Copy link
Member

Seems better to have all that separated from Core in the changelog.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Is that really all we need to do? :) sweet!

paulirish added a commit to paulirish/commitlintbot that referenced this pull request Aug 21, 2018
@paulirish paulirish changed the title i18n: add i18n 'type' for prlint i18n: add i18n 'type' for prlint Aug 21, 2018
@paulirish paulirish changed the title i18n: add i18n 'type' for prlint i18n: add i18n 'type' for prlin Aug 21, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

i18n: add i18n 'type' for prlin

Seems more misc than i18n to me :P

Also what's prlin

@patrickhulce
Copy link
Collaborator

prlin

I think that's supposed to be prlint

@paulirish paulirish changed the title i18n: add i18n 'type' for prlin i18n: add i18n 'type' for prlint Aug 21, 2018
@paulirish paulirish changed the title i18n: add i18n 'type' for prlint i18n: add i18n 'type' for prlin Aug 21, 2018
@paulirish paulirish changed the title i18n: add i18n 'type' for prlin i18n: add i18n 'type' for prlint Aug 21, 2018
@paulirish paulirish merged commit f660800 into master Aug 21, 2018
@paulirish paulirish deleted the i18ncommit branch August 21, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants