core(content-width): not applicable on desktop #5893
Conversation
There was a problem hiding this comment.
but honestly the whole PWA category should be taken with a grain of salt if you're not auditing with mobile (toplevel warning perhaps? or maybe the justification for category level warning 😄)
Definitely. Top level warning might be the best idea until we have a real solution for this future world of ChromeOS/Windows desktop PWAs
| const viewportWidth = artifacts.ViewportDimensions.innerWidth; | ||
| const windowWidth = artifacts.ViewportDimensions.outerWidth; | ||
| const widthsMatch = viewportWidth === windowWidth; | ||
|
|
||
| if (context.settings.disableDeviceEmulation) { |
There was a problem hiding this comment.
wouldn't this be disabled if you're running on a real phone, though?
There was a problem hiding this comment.
Hm, yes it would. Maybe a HostUserAgent plus disableDeviceEmulation check? Probably worth rolling up into a generic context isMobile boolean
There was a problem hiding this comment.
OTOH, I'm somewhat convinced this is essentially a redundant check with the viewport one, so I'm not inclined to go crazy propping it up.
There was a problem hiding this comment.
fwiw this does also not work for the lr-desktop preset.
but it looks like we're going to use viewport emulation for lr-desktop now, with viewport of 1366x768 and mobile:false, to fix a screenshot bug.
So we also have that situation to contend with. :)
|
Seems like this has been referenced in a few issues as a fix, anyone else wanna take a look? :) |
|
discussed a bit in the meeting. seems like
I think this captures the cases we described above. that sound right? |
sounds great! |
https://twitter.com/gcmznt/status/1032188854130880512 got me thinking that since the audit is just useless in DevTools without emulation we should mark it as not applicable. The meta tag should still capture this concern on the desktop site, but honestly the whole PWA category should be taken with a grain of salt if you're not auditing with mobile (toplevel warning perhaps? or maybe the justification for category level warning 😄)