core(gather-runner): call clearDataForOrigin on teardown #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Aug 30, 2018
| @@ -444,6 +445,7 @@ class GatherRunner { | |||
| firstPass = false; | |||
| } | |||
| } | |||
| await driver.clearDataForOrigin(options.requestedUrl); | |||
There was a problem hiding this comment.
seems like we should only do this if (!options.settings.disableStorageReset) === true like the previous call.
paulirish
approved these changes
Aug 30, 2018
paulirish
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all :)
Summary
What this change does: always clear browser cache for reqested URL after successfull lighthouse run.
See issue below. Besides, it's always good advice to free resources in computing after specific task is done properly.
Related Issues/PRs
#4889
I'm off for now. Support on this PR is welcome :)
Cheers
midzer