report: add html report viewing support for safari #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rops that were commented.
paulirish
requested changes
Oct 2, 2018
| } | ||
|
|
||
| /* Keep bytes columns narrow if they follow the URL column */ | ||
| /* Keep columns narrow if they follow the URL column */ | ||
| /* 12% width was found to be a good width for en and i18n without being too wide */ |
There was a problem hiding this comment.
12% was determined to be a decent narrow width, but wide enough for column headings
| @@ -83,7 +85,8 @@ | |||
| <template id="tmpl-lh-opportunity"> | |||
| <div class="lh-audit lh-audit--load-opportunity"> | |||
| <details class="lh-expandable-details"> | |||
| <summary class="lh-audit__header lh-expandable-details__summary"> | |||
| <summary> | |||
| <div class="lh-audit__header lh-expandable-details__summary"> | |||
| <div class="lh-load-opportunity__cols"> | |||
There was a problem hiding this comment.
need some indentation fixes here
| .lh-table-column--url + .lh-table-column--bytes + th.lh-table-column--timespanMs { | ||
| max-width: var(--bytes-col-width); | ||
| width: 12%; | ||
| } | ||
|
|
||
| .lh-table-column--code { |
There was a problem hiding this comment.
while you're here, i notice that this var doesnt exist anymore.
it's used on these two audits at least
seems like its fine without a max-width being set.
patrickhulce
reviewed
Oct 3, 2018
| @@ -648,6 +646,7 @@ | |||
| } | |||
|
|
|||
| .lh-header-sticky { | |||
| position: -webkit-sticky; | |||
There was a problem hiding this comment.
the time almost certainly isn't now, but do you see a path of us bringing in some build process with prefixers?
paulirish
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added Safari support! Main areas of focus were: