core(network): handle invalid NetworkRequests #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Oct 2, 2018
brendankenny
reviewed
Oct 2, 2018
|
@exterkamp should we add this to our smoke tests? Would it be easy to add the @font-face thing to https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html? The expectations shouldn't need to be updated, the test would just be that the run completes and the results still come back as expected before. |
|
we'll punt on the smoke test to a future change (pending getting it to work in a non-complicated way :) |
This was referenced Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
isValidproperty to a NetworkRequest and ignores invalid requests when making the list of records to surface to rest of application.Related Issues/PRs
fixes: #6145