Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): fix tooltip hover animation #6288

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Oct 16, 2018

Summary
Fixes the report hover bug on report.

demo:
http://wardpeet-filestorage.surge.sh/lh-store/pr-6288/report.html

Related Issues/PRs
#5796

@wardpeet wardpeet changed the title fix(report): fix hover animation fix(report): fix tooltip hover animation Oct 16, 2018
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!! 💯

@@ -1053,5 +1054,5 @@
@keyframes fadeInTooltip {
0% { opacity: 0; }
75% { opacity: 1; }
100% { opacity: 1; filter: drop-shadow(1px 0px 1px #aaa) drop-shadow(0px 2px 4px hsla(206, 6%, 25%, 0.15)); }
100% { opacity: 1; filter: drop-shadow(1px 0px 1px #aaa) drop-shadow(0px 2px 4px hsla(206, 6%, 25%, 0.15)); pointer-events: auto; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL :)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👻 :hovercar:

@paulirish paulirish merged commit ff1314d into master Oct 17, 2018
@paulirish paulirish deleted the fix/report-hover branch October 17, 2018 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants