core(driver): stringify protocol error messages #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Howdy chief! Appreciate you filing this bug. 👏 We think this is the same root issue as #1091. So, we'll automatically mark this as a duplicate. Thanks! |
|
lol #crushedbydevtoolsbot |
patrickhulce
approved these changes
Oct 17, 2018
paulirish
added a commit
that referenced
this pull request
Oct 17, 2018
This reverts commit c92142f.
paulirish
added a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an actual log from LR:
The true origin is most likely... (drumroll...)
Our best friend. 👨❤️👨
As to why this PR makes sense.. Well... I can't really explain why
messagehere is sometimes an object (and otherwise a string)... but the log above seems to indicate that's precisely what's happening. Could be the flu shot making me crazy though. 🤷♂️