Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: Remove "sh" format for CLI --help output #6311

Merged
merged 1 commit into from
Oct 17, 2018
Merged

readme: Remove "sh" format for CLI --help output #6311

merged 1 commit into from
Oct 17, 2018

Conversation

connorjclark
Copy link
Collaborator

It was making random words pretty colors :)

@connorjclark
readme: Remove "sh" format for CLI --help output
e185699 
It was making random words pretty colors :)
brendankenny
brendankenny reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree the random for, in, wait, etc highlights are weird. I do kind of like the highlighted quoted strings and angle brackets :)

patrickhulce
patrickhulce approved these changes Oct 17, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, yeah makes it a bit confusing :)

LGTM!

@brendankenny brendankenny merged commit 3f9ae17 into master Oct 17, 2018
@brendankenny brendankenny deleted the Hoten-patch-1 branch October 17, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny left review comments

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @brendankenny @patrickhulce