test: use predictable numbers in golden LHR #6404
Conversation
|
Can we rename |
been wanting to for a while. I'll do it after this PR |
|
what, it's not obvious what |
|
for test failures, see #6405 :) |
| const lhr = JSON.parse(lhrString); | ||
| delete lhr.configSettings.auditMode; |
There was a problem hiding this comment.
was there an issue with having this previously? Was it only because we were generating it more manually?
There was a problem hiding this comment.
its just this:
auditMode": "./lighthouse-core/test/results/artifacts",hopefully it isn't an absolute path in some cases?
| lhr.timing.total = 12345.6789; | ||
| lhr.timing.entries.forEach((entry, i) => { | ||
| // @ts-ignore | ||
| entry.duration = 100; |
There was a problem hiding this comment.
why are these ignored? readonly? Maybe we don't want them to descend from PerformanceEntry after all :)
Should put a reason why it's being ignored. e.g. // @ts-ignore - write to readonly property or whatever
| // Set to predictable and typical value | ||
| lhr.configSettings.auditMode = false; | ||
|
|
||
| // Set timing values, which change from run-to-run, to predicable values |
There was a problem hiding this comment.
if we're jumping on the comments there's also a t missing from predictable :)
| // @ts-ignore | ||
| entry.duration = 100; | ||
| // @ts-ignore | ||
| entry.startTime = 100 * i + i; // 1ms gap between them |
There was a problem hiding this comment.
if we add new entries this is going to cause some noise. What about based on length of the name or some kind of hash of the name or something?
There was a problem hiding this comment.
k. behold our new predictable timing trace!
paulirish
force-pushed
the
predictablenumbers
branch
from
0a013ac
to
e4039b3
Compare
paulirish
force-pushed
the
predictablenumbers
branch
from
145d73a
to
e4817a8
Compare
No more excluding items from the golden LHR.