extension: return runnerResult #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conform with the given return type definition.
connorjclark
requested review from
patrickhulce and
paulirish
as code owners
|
Also, it may be masking errors in the extension test: https://github.com/GoogleChrome/lighthouse/blob/master/clients/test/extension/extension-test.js#L94 |
whitespace
paulirish
reviewed
Dec 18, 2018
| @@ -104,6 +104,8 @@ async function runLighthouseInExtension(flags, categoryIDs) { | |||
| const reportHtml = /** @type {string} */ (runnerResult.report); | |||
| const blobURL = createReportPageAsBlob(reportHtml); | |||
| await new Promise(resolve => chrome.windows.create({url: blobURL}, resolve)); | |||
|
|
|||
| return runnerResult; | |||
There was a problem hiding this comment.
can you update the return type, too? Since the undefined branch throws an error now, void isn't necessary any more
yeah, we shouldn't have had a lack-of-something test by itself in JS :) |
|
discussed with @hoten, I'll take the test fix cause I see a few other things it would be nice to clean up in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change in behavior.
I noticed that this function was typed to return a runner result, but it never does. It would be useful for #6831 if it actually did.