deps: update cssstyle to parse more named colors, CSS4 colors #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this adds 2.6 KB to the bundle (.8 KB after gzip), almost entirely due to the newly added named colors |
| @@ -455,4 +455,99 @@ describe('Manifest Parser', function() { | |||
| assert.equal(url0, undefined); | |||
| }); | |||
| }); | |||
|
|
|||
| describe.only('background_color, theme_color', () => { | |||
There was a problem hiding this comment.
d'oh, they should have a test test for that :)
LGTY but needs approval :) |
patrickhulce
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
90% of this is tests :)
(
manifest-parser.jshad no existing tests for its color parsing)(edit: unit tests. It does have integration tests through
themed-omnibox,splash-screen, et al.)fixes #7139