deps: updates to weed out transitive vulnerabilities #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Feb 25, 2019
| "commitizen": "^2.9.6", | ||
| "conventional-changelog-cli": "^1.3.4", | ||
| "coveralls": "^2.11.9", | ||
| "coveralls": "^3.0.3", |
There was a problem hiding this comment.
codecov and coveralls had to go up a major version to get the latest request
brendankenny
commented
Feb 25, 2019
| @@ -113,9 +113,6 @@ | |||
| "eslint-config-google": "^0.9.1", | |||
| "gh-pages": "^2.0.1", | |||
| "glob": "^7.1.3", | |||
| "gulp": "^3.9.1", | |||
| "gulp-replace": "^0.5.4", | |||
| "gulp-util": "^3.0.7", | |||
There was a problem hiding this comment.
I was so excited about deleting these before, I don't know how I forgot to actually do it.
|
Travis isn't happy though. Maybe jsdom doesn't like the new changes 🤷♂️ |
ok, not sure what happened, but made the changes in a slightly different order and should be good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alerted by the github UI about a few vulnerable transitive dependencies. Almost all are descended from devDependencies (and the rest don't end up running, AFAICT), so they aren't a huge deal, but better to move off them.
This involved mostly removing and then re-adding the same dependency to get yarn to update transitive ones, but a few had to be manually updated in the
package.json.NineTen have been eliminated, but acouple remainone remains. We need to get finally get rid of mocha (or update to latest, but I didn't want to change that without testing) to get rid of oneand there's one last one I haven't figured out yet.